Openwall GNU/*/Linux - a small security-enhanced Linux distro for servers
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sat, 8 Sep 2012 17:33:48 +0530
From: Dhiru Kholia <dhiru.kholia@...il.com>
To: john-dev@...ts.openwall.com
Subject: Re: New formats: KRB5-18 and KRB5-23

On Sat, Sep 8, 2012 at 4:30 PM, magnum <john.magnum@...hmail.com> wrote:
> On 7 Sep, 2012, at 20:30 , Camille Mougey <commial@...il.com> wrote:
> It fails on Linux too when built with OMP. One of the formats (can't remember which now) stopped failing with OMP_NUM_THREADS=1, the other failed anyway.

The following patch fixes the Linux OMP problem.

diff --git a/src/krb5-18_fmt.c b/src/krb5-18_fmt.c
index cff6e3e..e0adf04 100644
--- a/src/krb5-18_fmt.c
+++ b/src/krb5-18_fmt.c
@@ -68,9 +68,6 @@ static char (*saved_key)[PLAINTEXT_LENGTH + 1];
 static char saved_salt[SALT_SIZE];
 static ARCH_WORD_32 (*crypt_out)[16];

-static krb5_error_code ret;
-static krb5_data string;
-static krb5_keyblock key;
 static krb5_data salt;
 static krb5_enctype enctype;

@@ -184,7 +181,9 @@ static void crypt_all(int count)
   for (index = 0; index < count; index++)
 #endif
     {
-
+      krb5_data string;
+      krb5_error_code ret;
+      krb5_keyblock key;
       salt.data = saved_salt;
       salt.length = strlen(salt.data);
       string.data = saved_key[index];


Does it look okay to you? I will commit this to magnum-jumbo once I
get positive feedback.

-- 
Cheers,
Dhiru

Powered by blists - more mailing lists

Your e-mail address:

Powered by Openwall GNU/*/Linux - Powered by OpenVZ