[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sun, 19 Aug 2012 00:03:46 +0200
From: magnum <john.magnum@...hmail.com>
To: john-dev@...ts.openwall.com
Subject: Re: OSX 10.8 (GT 650M) build fail
On 2012-08-18 20:06, Solar Designer wrote:
> On Sat, Aug 18, 2012 at 07:58:08PM +0200, magnum wrote:
>> On 2012-08-18 12:00, myrice wrote:
>>> sed -n 's/^\(struct fmt_main [^ ]*\) =.*/extern \1;/p' *_fmt_plug.c >
>>> fmt_externs.h
>>> sed: RE error: illegal byte sequence
>
> BTW, this means that we have 8-bit chars that are not part of valid
> UTF-8 sequences in the *_fmt_plug.c files. We might want to get rid of
> those weird chars (likely iso-8859-1 in a contributor's name?)
Yes I've seen some 8859-1 and also something that had been UTF-8 but
then was crippled by some utterly flawed editor. I'll soon commit a fix
that converts all of them to UTF-8. There were author's names but mostly
copyright signs (I still like (c) better, maybe I'm just old).
>>> It is osx 10.8 has strict sed. I add LANG=C to make macosx-x86-64-opencl
>>>
>>> The interesting thing is, when I first run this command, the error
>>> still there. But the second will be okay.
>>
>> I added "LC_ALL = C" to Makefile a while ago to remedy this problem but
>> apparently that was not the correct way to do it (I was shooting in the
>> dark).
>
> I think we shouldn't be changing these settings in the Makefile globally
> unless we truly have to. A better way may be to do this just for the
> sed invocations, like this:
>
> LANG=C sed ...
Yes. I'll fix this too.
magnum
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
