Openwall GNU/*/Linux - a small security-enhanced Linux distro for servers
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Thu, 16 Aug 2012 02:49:54 +0200
From: magnum <john.magnum@...hmail.com>
To: john-dev@...ts.openwall.com
Subject: Re: SRP

On 2012-08-16 02:44, jfoug@....net wrote:
>> On 2012-08-15 19:20, jfoug wrote:
>>> I have fixed the warnings, and added OMP.  The change has been pushed
>>> to jumbo-bleeding (9c0169a).
>>
>> You should have pushed it to magnum-jumbo. Now I had to cherry-pick the
>> fixes "backwards" to magnum-jumbo and could not avoid it being merged
>> back as a dupe no-op commit to bleeding, confusing history. No problem,
>> just consider this for future patches.
> 
> Sorry, I thought it was only pushed to bleeding. Also, that format has
> format version #defines in it, so it 'should' be safe to have exact same
> file in mag-jumbo as in mag-bleeding.

No problem. The version-independant format structs I really like. Dhiru
has learned them too, thank God!

> I will have to look to see what the problem is. I may have not properly
> done an #if 1 or something. I have some code in there, that I am pretty
> sure will ONLY work on LE 32 bit systems.  It was really only a test, to
> try to squeeze more out of GMP, by avoiding setter and getter code.  But
> it did not impact speed, a great deal.

I did some PDQ checks but did not find the problem. No sweat as long as
it builds.

magnum


Powered by blists - more mailing lists

Your e-mail address:

Powered by Openwall GNU/*/Linux - Powered by OpenVZ