Openwall GNU/*/Linux - a small security-enhanced Linux distro for servers
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 8 Aug 2012 10:36:00 -0500
From: "jfoug" <jfoug@....net>
To: <john-dev@...ts.openwall.com>
Cc: <pavel@...janov.com>
Subject: RE: Patch for pkzip_fmt_plug.c  from jumbo-6

I have done both of these with encryption, and both crack (older code).

Note, the code was NEVER intended to be proper .zip processing.  Just to
detect that if the current password is used, that the decoded stream is
invalid.

Possibly I need to make more tests, using different passwords (I will setup
a script to do just that).  But with this initial test, the old code appears
to not miss anything.

Can  you validate that the .zip stream sent imploaded the data properly, and
that something simple like that did not cause these test files to succeed.
I am going to make many crypt files (using different passwords), on the same
data, and see if JtR misses any of them.

Note the password is 'password' in both .zip files.

Jim.

>From: Pavel Semjanov [mailto:pavel@...janov.com]
>Sent: Monday, August 06, 2012 7:16 AM
>To: john-dev@...ts.openwall.com
>Cc: magnum
>Subject: Re: [john-dev] Patch for pkzip_fmt_plug.c from jumbo-6
>
>> On 2012-07-27 11:10, Pavel Semjanov wrote:
>>> Hello,
>>>
>>>    I've tested and fixed some errors (one is severe, the code was not
>>> working on some files!) in function check_inflate_CODE1().
>>> The patch is attached.
>>>s
>>
>> Pavel,
>>
>> Thanks, this is really appreciated! Could you possibly supply test
>> files showing the problem? This would make our audit a lot easier and
>faster.
>
>I've attached two files. The first one (future.zip) has a false early
>reject. The second one passes ok early reject, but only by accident - it
>has end-of-block marker in the first 8 bytes, so the logic of the
>function is wrong.

[ CONTENT OF TYPE application/x-zip-compressed SKIPPED ]

[ CONTENT OF TYPE application/x-zip-compressed SKIPPED ]

Powered by blists - more mailing lists

Your e-mail address:

Powered by Openwall GNU/*/Linux - Powered by OpenVZ