Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 6 Aug 2012 12:16:39 +0200
From: Lukas Odzioba <lukas.odzioba@...il.com>
To: john-dev@...ts.openwall.com
Subject: Re: Current -fixes GPU formats vs TS

2012/8/6 Frank Dittrich <frank_dittrich@...mail.com>:
> On 08/06/2012 05:12 AM, Lukas Odzioba wrote:
>> 2012/8/6 magnum <john.magnum@...hmail.com>:
>>> form=mscash-cuda                  guesses: 1216 time: 0:00:00:00 :
>>> Expected count(s) (1500)  [!!!FAILED!!!]
>
> The attached patch also appends new test cases for the self test (which
> is good), but apparently uses tests that are not used in the CPU format,
> without adding them to the CPU format test cases.
> I think we should aim at using the same test cases in different
> implementations of a format.

Generally I agree with one exception. What if some gpu format like
"raw-sha256" supports limited plaintext length in comparison to cpu
version.?
Other thing is that if we want to have common tests, only way to do
that well is move tests to external file included by fmt files.

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.