Openwall GNU/*/Linux - a small security-enhanced Linux distro for servers
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date: Sun, 8 Jul 2012 08:13:04 +0200
From: Frank Dittrich <frank_dittrich@...mail.com>
To: john-dev@...ts.openwall.com
Subject: Inconsistencies in dynamic format names

This can be seen in the output of --subformat=list as well as in the
output of --test:

dynamic_0: md5($p) (raw-md5)
dynamic_1: md5($p.$s) (joomla)
dynamic_34: md5(md4($p))
dynamic_1001 md5(md5(md5(md5($p))))
dynamic_1002 md5(md5(md5(md5(md5($p)))))
dynamic_1010 dynamic_1010: RAdmin v2.x MD5

For dynamic_1010, dynamic.conf needs to be changed.
Expression=RAdmin v2.x MD5
instead of
Expression=dynamic_1010: RAdmin v2.x MD5

Since this has just been added yesterday, I don't think I need to adjust
benchmark-unify.

So, there's a simple patch attached


The other "problem" is that the built-in format names are printed with a
colon, whereas the user-specified aren't.
Should this be unified? If yes, which way?
If this gets unified, the benchmark-unify script needs to be adjusted as
well, but that is trivial.

Frank

>From 7aec9bc4d0b72e7e6ce1f246d967d0d946db063e Mon Sep 17 00:00:00 2001
From: Frank Dittrich <frank_dittrich@...mail.com>
Date: Sun, 8 Jul 2012 08:09:28 +0200
Subject: [PATCH] Fix dynamic_1010 format name

---
 run/dynamic.conf |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/run/dynamic.conf b/run/dynamic.conf
index f13cc3a..3731470 100644
--- a/run/dynamic.conf
+++ b/run/dynamic.conf
@@ -222,7 +222,7 @@ Func=DynamicFunc__crypt_md5
 Test=$dynamic_1009$0b9b9fdf75fc79d85c5b69aa1de26288$Salt:test1
 
 [List.Generic:dynamic_1010]
-Expression=dynamic_1010: RAdmin v2.x MD5
+Expression=RAdmin v2.x MD5
 Flag=MGF_NOTSSE2Safe
 Func=DynamicFunc__clean_input
 Func=DynamicFunc__append_keys
-- 
1.7.7.6


Powered by blists - more mailing lists

Your e-mail address:

Powered by Openwall GNU/*/Linux - Powered by OpenVZ