[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sun, 8 Jul 2012 22:18:25 +0530
From: Dhiru Kholia <dhiru.kholia@...il.com>
To: john-dev@...ts.openwall.com
Subject: Re: Format writing 101
On Sun, Jul 8, 2012 at 9:40 PM, <jfoug@....net> wrote:
> I think (after looking at SIP format), that we REALLY need to generate a FAQ on how to build a proper format under JtR.
>
> After looking at the SIP format, and others over time, I really think a mini 'how to' would be nice. The SIP format as implemented, contains a ton of work being done in the set_salt. That is the wrong place to do that work. Solar made some changes to help 'hide' this problem (bumped up the password count to 64, from 1). The speed on my system did go from about 88k to 900k with Solar's change. In a real fast hack (needs work still), I moved this work into get_hash, and removed all the allocations. With that change, it is running along at about 1200k, however, like I said, there still is work to be done. I think I have likely caused JtR to fail to have dupe salt elimination.
My bad. SIP format was a very quick hack and I never got around to
fixing it (like I have fixed my other formats). Lot of the code from
set_salt belongs in get_salt. Also, I think that the whole cracked
array approach can be removed from the SIP format.
--
Cheers,
Dhiru
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
