[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 28 Jun 2012 14:59:02 +0530
From: Dhiru Kholia <dhiru.kholia@...il.com>
To: john-dev@...ts.openwall.com
Subject: Re: linux-x86-clang build broken: UTF-8 byte order mark
detected in 'keepass2john.c', but encoding is not supported
On Thu, Jun 28, 2012 at 2:44 PM, magnum <john.magnum@...hmail.com> wrote:
> On 2012-06-28 11:08, Frank Dittrich wrote:
>> On 06/28/2012 10:49 AM, magnum wrote:
>>> On 2012-06-28 10:46, Frank Dittrich wrote:
>>>> $ file keepass2john.c
>>>> keepass2john.c: UTF-8 Unicode (with BOM) English text
>>>
>>> UTF-8 BOM is the worst idea ever. I will fix.
>>
>> The funny thing is that with git diff I saw the removed BOM, but in the
>> patch created with git format-patch and on github you don't see any
>> differences.
>
> It's the same when you fix legacy line endings. I'm not sure why it even
> works, but it does.
>
>> Isn't there some git magic which prevents accidentally committing such
>> files, or some pre-commit hook to remove BOMs (and trailing spaces) from
>> .c/.h files?
Thanks for fixing this. I couldn't remove the BOM myself. I still
don't know how I got it in the first place ;)
--
Cheers,
Dhiru
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
