Date: Wed, 27 Jun 2012 20:08:06 -0500 From: "jfoug" <jfoug@....net> To: <john-dev@...ts.openwall.com> Subject: RE: fake_salts.o has 52 MB of BSS That code CERTAINLY needed fixed. The HUGE memory suck, even in the almost certain case of it not being used was very bad. I have shot off another patch to Magnum, fixing a few things. There were issues in kee_pass_fmt_plug.c and hcapp2john.c. These issues were fixed (VC build). #include <stdint.h> changed to #include "stdint.h" (to use the stdint.h INSIDE Jtr's source. Some #ifndef _MSC_VER for things like unistd.h Vars not at top of blocks (I think Solar already pointed this out). atoll required a #define (under _MSC_VER build) to use _atoi64 For now, I just put the atoll -> _atoi64 in kee_pass_fmt.c but it probably should be with the other _MSC_VER string type #define patch is at (misc.h I think). If that function gets used anywhere else, I think that would be where to put it, but for now, I simply put it in the format. Jim. >From: magnum [mailto:john.magnum@...hmail.com] > >I have tested it now. Works like a champ. I'll commit it to magnum-jumbo >too and hope Solar took a nap so it might still be included. > >btw I looked at the wrong column, it was actually 644x larger than the >second worst.
Powered by blists - more mailing lists
Powered by Openwall GNU/*/Linux - Powered by OpenVZ