Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 27 Jun 2012 18:12:26 +0400
From: Solar Designer <solar@...nwall.com>
To: john-dev@...ts.openwall.com
Subject: Re: keepass2john.c

On Wed, Jun 27, 2012 at 07:11:37PM +0530, Dhiru Kholia wrote:
> I have committed KeePass format to magnum-jumbo. So, please include
> keepass2john.c in jumbo-6. Thanks!

Can you integrate it properly (Makefile, john.c)?

Also, fixing this is a must:

keepass_fmt_plug.c: In function 'transform_key':
keepass_fmt_plug.c:78:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
keepass_fmt_plug.c: In function 'get_salt':
keepass_fmt_plug.c:129:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
keepass_fmt_plug.c: In function 'crypt_all':
keepass_fmt_plug.c:198:3: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]

and perhaps we should in fact add -Wdeclaration-after-statement to
default CFLAGS.

Thanks,

Alexander

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.