[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sun, 24 Jun 2012 11:49:03 -0700 (PDT)
From: deepika dutta <deepikadutta_19@...oo.com>
To: "john-dev@...ts.openwall.com" <john-dev@...ts.openwall.com>
Subject: Re: mschap-v2 conversion
Hi, I looked into the problem, the testsuite is fine. Problem is with the DES_bs_set_key() function where each byte of key is being checked for 0 and if some byte is found to be 0, all the next key bytes are taken to be 0.
For all the cases where the testsuite failed, failure occurred in mschapv2_cmp_exact() where the key was 0 at one of the bytes and due to above check in DES key setting, the DES key changed from the actual key which changed the ciphertext and cmp_exact failed.
I removed the check for 0 from DES_bs_set_key() and ran the test suite, it was successful for all 1500 cases. I don't understand the need for this check for 0 of each key byte, whether this can be removed?
Cheers,
Deepika
________________________________
From: magnum <john.magnum@...hmail.com>
To: john-dev@...ts.openwall.com
Sent: Monday, June 4, 2012 12:16 PM
Subject: Re: [john-dev] mschap-v2 conversion
On 06/04/2012 08:07 AM, deepika dutta wrote:
> Hi, did anyone test the patch? And what about the SSE work?
Here's output from our Test Suite (as found in http://openwall.info/wiki/john/patches#Other-files-closely-related-to-patches-found-on-this-page):
magnum@...ge:test [master]$ ./jtrts.pl mschapv2
-------------------------------------------------------------------------------
- JtR-TestSuite (jtrts). Version 1.12.2, June 3, 2012. By, Jim Fougeron & others
- Testing: John the Ripper password cracker, ver: 1.7.9-jumbo-5+unstable_omp [generic]
--------------------------------------------------------------------------------
John Jumbo build detected.
testing: john -test=0
form=mschapv2 guesses: 1405 time: 0:00:00:00 : Expected count(s) (1500) [!!!FAILED!!!]
.pot CHK:mschapv2 guesses: 1405 time: 0:00:00:00 [PASSED]
form=mschapv2-utf8 guesses: 1390 time: 0:00:00:00 : Expected count(s) (1500) [!!!FAILED!!!]
.pot CHK:mschapv2-utf8 guesses: 1390 time: 0:00:00:00 [PASSED]
form=mschapv2-koi8r guesses: 1385 time: 0:00:00:00 : Expected count(s) (1500) [!!!FAILED!!!]
.pot CHK:mschapv2-koi8r guesses: 1385 time: 0:00:00:00 [PASSED]
form=mschapv2-cp1251 guesses: 1387 time: 0:00:00:00 : Expected count(s) (1500) [!!!FAILED!!!]
.pot CHK:mschapv2-cp1251 guesses: 1387 time: 0:00:00:00 [PASSED]
form=mschapv2-cp866 guesses: 1384 time: 0:00:00:00 : Expected count(s) (1500) [!!!FAILED!!!]
.pot CHK:mschapv2-cp866 guesses: 1384 time: 0:00:00:00 [PASSED]
form=mschapv2-cp850 guesses: 1413 time: 0:00:00:00 : Expected count(s) (1500) [!!!FAILED!!!]
.pot CHK:mschapv2-cp850 guesses: 1413 time: 0:00:00:00 [PASSED]
form=mschapv2-cp858 guesses: 1412 time: 0:00:00:00 : Expected count(s) (1500) [!!!FAILED!!!]
.pot CHK:mschapv2-cp858 guesses: 1412 time: 0:00:00:00 [PASSED]
form=mschapv2-cp737 guesses: 1422 time: 0:00:00:00 : Expected count(s) (1500) [!!!FAILED!!!]
.pot CHK:mschapv2-cp737 guesses: 1422 time: 0:00:00:00 [PASSED]
form=mschapv2-cp437 guesses: 1419 time: 0:00:00:00 : Expected count(s) (1500) [!!!FAILED!!!]
.pot CHK:mschapv2-cp437 guesses: 1419 time: 0:00:00:00 [PASSED]
form=mschapv2-iso8859-15 guesses: 1400 time: 0:00:00:00 : Expected count(s) (1500) [!!!FAILED!!!]
.pot CHK:mschapv2-iso8859-15 guesses: 1400 time: 0:00:00:00 [PASSED]
form=mschapv2-cp1252 guesses: 1404 time: 0:00:00:00 : Expected count(s) (1500) [!!!FAILED!!!]
.pot CHK:mschapv2-cp1252 guesses: 1404 time: 0:00:00:00 [PASSED]
Some tests had Errors. Performed 11 tests.11 errors
Time used was 25 seconds
You might want to install the Test Suite and debug it.
magnum
Content of type "text/html" skipped
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
