[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 13 Jun 2012 09:36:49 +0200
From: magnum <john.magnum@...hmail.com>
To: john-dev@...ts.openwall.com
Subject: Re: GPU fixes
On 2012-06-02 16:15, magnum wrote:
> Committed now, thanks.
>
> On 06/02/2012 03:57 AM, Lukas Odzioba wrote:
>> Magnum,all:
>> Finally I did what I promised long time ago. If you will have any
>> suggestions please tell me, I should be more responsive in fixing code
>> now.
>> Patch should go nicely over magnum's your repository.
>> Changes:
Lukas,
We still get several screenfuls of compiler warnings when building,
mostly from wpapsk. Do you intend to fix this? Otherwise I'll do it. I
am fed up with them. Also, additional warnings in other places were
introduced by your latest GPU patch (not the device list one).
FWIW I almost *always* "make >/dev/null" so I see what warnings I may
have introduced, and if I see any, I fix them.
In file included from hccap2john.c:18:0:
wpapsk.h:126:43: warning: ‘struct fmt_main’ declared inside parameter
list [enabled by default]
wpapsk.h:126:43: warning: its scope is only this definition or
declaration, which is probably not what you want [enabled by default]
wpapsk.h:111:14: warning: ‘binary’ defined but not used [-Wunused-function]
wpapsk.h:119:14: warning: ‘salt’ defined but not used [-Wunused-function]
wpapsk.h:126:12: warning: ‘valid’ defined but not used [-Wunused-function]
wpapsk.h:164:13: warning: ‘set_salt’ defined but not used
[-Wunused-function]
wpapsk.h:171:13: warning: ‘set_key’ defined but not used [-Wunused-function]
wpapsk.h:178:14: warning: ‘get_key’ defined but not used [-Wunused-function]
wpapsk.h:210:13: warning: ‘wpapsk_postprocess’ defined but not used
[-Wunused-function]
wpapsk.h:240:12: warning: ‘binary_hash_0’ defined but not used
[-Wunused-function]
wpapsk.h:253:12: warning: ‘binary_hash_1’ defined but not used
[-Wunused-function]
wpapsk.h:258:12: warning: ‘binary_hash_2’ defined but not used
[-Wunused-function]
wpapsk.h:263:12: warning: ‘binary_hash_3’ defined but not used
[-Wunused-function]
wpapsk.h:268:12: warning: ‘binary_hash_4’ defined but not used
[-Wunused-function]
wpapsk.h:273:12: warning: ‘binary_hash_5’ defined but not used
[-Wunused-function]
wpapsk.h:278:12: warning: ‘binary_hash_6’ defined but not used
[-Wunused-function]
wpapsk.h:283:12: warning: ‘get_hash_0’ defined but not used
[-Wunused-function]
wpapsk.h:297:12: warning: ‘get_hash_1’ defined but not used
[-Wunused-function]
wpapsk.h:303:12: warning: ‘get_hash_2’ defined but not used
[-Wunused-function]
wpapsk.h:309:12: warning: ‘get_hash_3’ defined but not used
[-Wunused-function]
wpapsk.h:315:12: warning: ‘get_hash_4’ defined but not used
[-Wunused-function]
wpapsk.h:321:12: warning: ‘get_hash_5’ defined but not used
[-Wunused-function]
wpapsk.h:327:12: warning: ‘get_hash_6’ defined but not used
[-Wunused-function]
wpapsk.h:333:12: warning: ‘cmp_all’ defined but not used [-Wunused-function]
wpapsk.h:344:12: warning: ‘cmp_one’ defined but not used [-Wunused-function]
wpapsk.h:355:12: warning: ‘cmp_exact’ defined but not used
[-Wunused-function]
common-opencl.c: In function ‘opencl_find_best_workgroup’:
common-opencl.c:212:10: warning: unused variable ‘localworksize’
[-Wunused-variable]
common_opencl_pbkdf2.c: In function ‘find_best_workgroup’:
common_opencl_pbkdf2.c:121:2: warning: format ‘%d’ expects argument of
type ‘int’, but argument 2 has type ‘size_t’ [-Wformat]
opencl_cryptmd5_fmt.c:68:15: warning: ‘global_work_size’ defined but not
used [-Wunused-variable]
In file included from opencl_wpapsk_fmt.c:15:0:
wpapsk.h: In function ‘decode_hccap’:
wpapsk.h:102:9: warning: array subscript is above array bounds
[-Warray-bounds]
opencl_pwsafe_fmt.c:71:15: warning: ‘global_work_size’ defined but not
used [-Wunused-variable]
opencl_pwsafe_fmt.c:95:13: warning: ‘find_best_workgroup’ declared
‘static’ but never defined [-Wunused-function]
cuda_pwsafe_fmt.c: In function ‘crypt_all’:
cuda_pwsafe_fmt.c:105:9: warning: implicit declaration of function
‘gpu_pwpass’ [-Wimplicit-function-declaration]
In file included from cuda_wpapsk.h:8:0,
from cuda_wpapsk_fmt.c:12:
wpapsk.h: In function ‘decode_hccap’:
wpapsk.h:102:9: warning: array subscript is above array bounds
[-Warray-bounds]
magnum
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
