Openwall GNU/*/Linux - a small security-enhanced Linux distro for servers
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Fri, 11 May 2012 04:39:33 +0400
From: Solar Designer <solar@...nwall.com>
To: john-dev@...ts.openwall.com
Subject: Re: compiling multiple external modes for --list=ext-* (was: bash auto-completion for john)

magnum -

On Fri, May 11, 2012 at 04:13:34AM +0400, Solar Designer wrote:
> On Fri, May 11, 2012 at 12:46:46AM +0200, magnum wrote:
> > @@ -940,7 +940,9 @@ void c_execute_fast(void *addr)
> >  #endif
> >                 int op = 0;
> > 
> > -               assert(c_op_return != &&op_return); /* Don't do this
> > twice */
> > +               /* Needed for -list option */
> > +               if (c_op_return == &&op_return) return;
> > +               //assert(c_op_return != &&op_return); /* Don't do this
> > twice */
> 
> This is mostly OK, but it prevents certain bugs from being detected.

Attached is a more elaborate patch to allow for c_compile() to be called
more than once.  It also frees memory allocated by the previous compile.

Alexander

View attachment "john-compiler-multi.diff" of type "text/plain" (1930 bytes)

Powered by blists - more mailing lists

Your e-mail address:

Powered by Openwall GNU/*/Linux - Powered by OpenVZ