[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Thu, 29 Mar 2012 12:33:28 +0530
From: Dhiru Kholia <dhiru.kholia@...il.com>
To: john-dev@...ts.openwall.com
Subject: Re: mozilla format minor problems
On Thu, Mar 29, 2012 at 11:56 AM, magnum <john.magnum@...hmail.com> wrote:
> On 03/29/2012 06:52 AM, Dhiru Kholia wrote:
>> Currently we have.
>>
>> CFLAGS = -c -Wall -O2 .. `pkg-config --cflags nss`
>>
>> Instead of this can we have:
>>
>> ifdef HAVE_NSS
>> CFLAGS = -c -Wall -O2 ... `pkg-config --cflags nss`
>> else
>> CFLAGS = -c -Wall -O2 ... $(JOHN_CFLAGS)
>>
>> And sample applies to LDFLAGS. Do you think this will solve the problem?
>
>
> This will be confusing (duplicated stuff). Maybe something like this is
> better, I did not test but I think it would work:
>
> # NSS (and NSPR) flag, un-comment this line if installed (enables
> mozilla format)
> #HAVE_NSS = -DHAVE_NSS `pkg-config --cflags nss`
>
> CFLAGS = -DRAR_USE_EVP -c -Wall -O2 -fomit-frame-pointer
> -I/usr/local/include $(HAVE_NSS) $(OMPFLAGS) $(JOHN_CFLAGS)
Looks good and seems that it will work.
--
Cheers,
Dhiru
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
