Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Fri, 23 Mar 2012 19:18:28 +0100
From: magnum <john.magnum@...hmail.com>
To: john-dev@...ts.openwall.com
Subject: Re: PoC cracker for Mozilla Firefox and Thunderbird passwords.

On 03/23/2012 03:44 PM, Dhiru Kholia wrote:
> On Fri, Mar 23, 2012 at 1:20 AM, magnum <john.magnum@...hmail.com> wrote:
>> I haven't really looked at your code yet, but the easiest way to avoid
>> self-test is to not provide any. This is in bench.c:
>>
>> /* Silently skip DIGEST-MD5 (for which we have no tests), unless forced */
>>                if (!format->params.tests && format != fmt_list)
>>                        continue;
> 
> How did earlier version of DIGEST-MD5 do it? I wrote NULL in place of
> mozilla_tests in struct fmt_main mozilla_fmt. However running the
> benchmark gives  "Benchmarking: Mozilla [32/64]... FAILED (no data)"
> message. Is this normal and expected message?

That's not happening if you do an all-formats --test (or better
--test=0), right? It will be silently skipped. If you specifically try
to test this format, that output is expected.

> I am adding OMP support for this patch currently and if there is
> enough interest maybe this patch can go in jumbo. What do you think?

Solar decides but I'd say we include it, especially since you've added
the HAVE_NSS stuff.

magnum

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.