Openwall GNU/*/Linux - a small security-enhanced Linux distro for servers
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 8 Nov 2011 10:18:07 -0600
From: "jfoug" <jfoug@....net>
To: <john-dev@...ts.openwall.com>
Subject: RE: algorithm info wrongly put in format_name

I believe what you are seeing is the 'BENCHMARK_FORMAT' value.

In dynamic_fmt.c, there is this code:

#ifdef MMX_TYPE
#define BENCHMARK_COMMENT	MMX_TYPE
#else
#define BENCHMARK_COMMENT		""
#endif

If we get rid of that code, then I believe that the output will be the way
you want it.

Simply changing the above 5 lines to this, I think will do the trick.

#define BENCHMARK_COMMENT		""


I am putting a patch on the wiki.

Jim.

>-----Original Message-----
>From: Solar Designer [mailto:solar@...nwall.com]
>Sent: Monday, November 07, 2011 5:43 PM
>To: john-dev@...ts.openwall.com
>Subject: [john-dev] algorithm info wrongly put in format_name
>
>Jim -
>
>In 1.7.8-jumbo-7 many formats put "MMX" into format_name instead of into
>algorithm_name, and three do it with "(8x)".  Maybe there are other
>variations and more affected formats with other builds.  I spotted this
>when trying out my relbench.pl script to compare a Pentium 3 (MMX build)
>vs. Core 2 (x86-64 build).  Is this something you'd fix now?
>
>Here's what I get from the script:
>
>Only in file 1:  md5_gen(15): md5($u.md5($p).$s)  MMX:Only one salt
>Only in file 1: PIX MD5 MMX:Raw
>Only in file 1:  md5_gen(16): md5(md5(md5($p).$s).$s2)  MMX:Only one
>salt
>Only in file 1: md5_gen(1001) md5(md5(md5(md5($p)))) MMX:Raw
>Only in file 1:  md5_gen(5): md5($s.$p.$s)  MMX:Only one salt
>Only in file 1:  md5_gen(14): md5($s.md5($p).$s)  MMX:Many salts
>Only in file 1:  md5_gen(24): sha1($p.$s) MMX:Only one salt
>Only in file 1:  md5_gen(9): md5($s.md5($p))  MMX:Only one salt
>Only in file 1: MS-SQL05 MMX:Many salts
>Only in file 1:  md5_gen(29): md5(unicode($p)) MMX:Raw
>Only in file 1:  md5_gen(13): md5(md5($p).md5($s))  MMX:Only one salt
>Only in file 1: Netscape LDAP SSHA MMX:Many salts
>Only in file 1:  md5_gen(25): sha1($s.$p) MMX:Only one salt
>Only in file 1:  md5_gen(22): md5(sha1($p)) MMX:Raw
>Only in file 1: MS-SQL MMX:Only one salt
>Only in file 1:  md5_gen(26): sha1($p) raw-sha1 MMX:Raw
>Only in file 1: MS-SQL MMX:Many salts
>Only in file 1:  md5_gen(13): md5(md5($p).md5($s))  MMX:Many salts
>Only in file 1:  md5_gen(6): md5(md5($p).$s)  MMX:Only one salt
>Only in file 1: MS-SQL05 MMX:Only one salt
>Only in file 1:  md5_gen(5): md5($s.$p.$s)  MMX:Many salts
>Only in file 1: md5_gen(1006) md5(md5(md5(md5(md5(md5(md5(md5($p))))))))
>MMX:Raw
>Only in file 1:  md5_gen(14): md5($s.md5($p).$s)  MMX:Only one salt
>Only in file 1: MySQL 4.1 double-SHA-1 MMX:Raw
>Only in file 1: md5_gen(1008) md5($p.$s) [joomla] MMX:Only one salt
>Only in file 1:  md5_gen(12): md5(md5($s).md5($p))  (IPB)  MMX:Only one
>salt
>Only in file 1:  md5_gen(0): md5($p)  (raw-md5)  MMX:Raw
>Only in file 1:  md5_gen(21): HTTP Digest Access Auth MMX:Only one salt
>Only in file 1:  md5_gen(17): phpass ($P$ or $H$)  MMX:Raw
>Only in file 1:  md5_gen(8): md5(md5($s).$p)  MMX:Many salts
>Only in file 1: Salted SHA:Many salts
>Only in file 1:  md5_gen(10): md5($s.md5($s.$p))  MMX:Many salts
>Only in file 1:  md5_gen(2): md5(md5($p))  (e107)  MMX:Raw
>Only in file 1: Salted SHA:Only one salt
>Only in file 1:  md5_gen(20): Cisco PIX (MD5 salted) MMX:Many salts
>Only in file 1: HMAC MD5 MMX:Raw
>Only in file 1:  md5_gen(18): md5($s.Y.$p.0xF7.$s) (Post.Office MD5)
>MMX:Only one salt
>Only in file 1: Netscape LDAP SHA MMX:Raw
>Only in file 1:  md5_gen(1): md5($p.$s)  (joomla)  MMX:Many salts
>Only in file 1:  md5_gen(11): md5($s.md5($p.$s))  MMX:Many salts
>Only in file 1:  md5_gen(8): md5(md5($s).$p)  MMX:Only one salt
>Only in file 1:  md5_gen(25): sha1($s.$p) MMX:Many salts
>Only in file 1:  md5_gen(4): md5($s.$p)  (OSC)  MMX:Many salts
>Only in file 1:  md5_gen(27): FreeBSD MD5 MMX:Raw
>Only in file 1:  md5_gen(1): md5($p.$s)  (joomla)  MMX:Only one salt
>Only in file 1:  md5_gen(11): md5($s.md5($p.$s))  MMX:Only one salt
>Only in file 1:  md5_gen(28): Apache MD5 MMX:Raw
>Only in file 1: md5_gen(1005) md5(md5(md5(md5(md5(md5(md5($p)))))))
>MMX:Raw
>Only in file 1:  md5_gen(6): md5(md5($p).$s)  MMX:Many salts
>Only in file 1: Raw SHA-1:Raw
>Only in file 1: md5_gen(1002) md5(md5(md5(md5(md5($p))))) MMX:Raw
>Only in file 1:  md5_gen(4): md5($s.$p)  (OSC)  MMX:Only one salt
>Only in file 1:  md5_gen(10): md5($s.md5($s.$p))  MMX:Only one salt
>Only in file 1:  md5_gen(12): md5(md5($s).md5($p))  (IPB)  MMX:Many
>salts
>Only in file 1:  md5_gen(3): md5(md5(md5($p)))  MMX:Raw
>Only in file 1:  md5_gen(16): md5(md5(md5($p).$s).$s2)  MMX:Many salts
>Only in file 1:  md5_gen(15): md5($u.md5($p).$s)  MMX:Many salts
>Only in file 1:  md5_gen(20): Cisco PIX (MD5 salted) MMX:Only one salt
>Only in file 1: md5_gen(1008) md5($p.$s) [joomla] MMX:Many salts
>Only in file 1:  md5_gen(9): md5($s.md5($p))  MMX:Many salts
>Only in file 1:  md5_gen(18): md5($s.Y.$p.0xF7.$s) (Post.Office MD5)
>MMX:Many salts
>Only in file 1: Netscape LDAP SSHA MMX:Only one salt
>Only in file 1:  md5_gen(24): sha1($p.$s) MMX:Many salts
>Only in file 1:  md5_gen(19): Cisco PIX (MD5) MMX:Raw
>Only in file 1:  md5_gen(23): sha1(md5($p)) MMX:Raw
>Only in file 1: md5_gen(1004) md5(md5(md5(md5(md5(md5($p)))))) MMX:Raw
>Only in file 1: md5_gen(1003) md5(md5($p).md5($p)) MMX:Raw
>Only in file 1:  md5_gen(21): HTTP Digest Access Auth MMX:Many salts
>Only in file 2: md5_gen(1001) md5(md5(md5(md5($p)))):Raw
>Only in file 2:  md5_gen(21): HTTP Digest Access Auth:Only one salt
>Only in file 2: Netscape LDAP SSHA:Only one salt
>Only in file 2: md5_gen(1002) md5(md5(md5(md5(md5($p))))):Raw
>Only in file 2:  md5_gen(5): md5($s.$p.$s) :Many salts
>Only in file 2: MS-SQL05:Many salts
>Only in file 2: md5_gen(1004) md5(md5(md5(md5(md5(md5($p)))))):Raw
>Only in file 2: Netscape LDAP SHA:Raw
>Only in file 2: Salted SHA(8x):Only one salt
>Only in file 2:  md5_gen(27): FreeBSD MD5:Raw
>Only in file 2:  md5_gen(5): md5($s.$p.$s) :Only one salt
>Only in file 2:  md5_gen(12): md5(md5($s).md5($p))  (IPB) :Many salts
>Only in file 2: MS-SQL:Only one salt
>Only in file 2:  md5_gen(11): md5($s.md5($p.$s)) :Only one salt
>Only in file 2:  md5_gen(10): md5($s.md5($s.$p)) :Many salts
>Only in file 2:  md5_gen(22): md5(sha1($p)):Raw
>Only in file 2:  md5_gen(16): md5(md5(md5($p).$s).$s2) :Many salts
>Only in file 2:  md5_gen(13): md5(md5($p).md5($s)) :Only one salt
>Only in file 2: PIX MD5:Raw
>Only in file 2: md5_gen(1008) md5($p.$s) [joomla]:Many salts
>Only in file 2: MS-SQL:Many salts
>Only in file 2:  md5_gen(14): md5($s.md5($p).$s) :Only one salt
>Only in file 2:  md5_gen(16): md5(md5(md5($p).$s).$s2) :Only one salt
>Only in file 2:  md5_gen(25): sha1($s.$p):Only one salt
>Only in file 2:  md5_gen(8): md5(md5($s).$p) :Many salts
>Only in file 2:  md5_gen(11): md5($s.md5($p.$s)) :Many salts
>Only in file 2:  md5_gen(9): md5($s.md5($p)) :Only one salt
>Only in file 2: MS-SQL05:Only one salt
>Only in file 2:  md5_gen(29): md5(unicode($p)):Raw
>Only in file 2:  md5_gen(14): md5($s.md5($p).$s) :Many salts
>Only in file 2:  md5_gen(23): sha1(md5($p)):Raw
>Only in file 2:  md5_gen(24): sha1($p.$s):Many salts
>Only in file 2:  md5_gen(26): sha1($p) raw-sha1:Raw
>Only in file 2:  md5_gen(1): md5($p.$s)  (joomla) :Many salts
>Only in file 2: md5_gen(1005) md5(md5(md5(md5(md5(md5(md5($p))))))):Raw
>Only in file 2:  md5_gen(6): md5(md5($p).$s) :Many salts
>Only in file 2:  md5_gen(19): Cisco PIX (MD5):Raw
>Only in file 2: MySQL 4.1 double-SHA-1:Raw
>Only in file 2: Netscape LDAP SSHA:Many salts
>Only in file 2:  md5_gen(2): md5(md5($p))  (e107) :Raw
>Only in file 2:  md5_gen(0): md5($p)  (raw-md5) :Raw
>Only in file 2:  md5_gen(28): Apache MD5:Raw
>Only in file 2:  md5_gen(6): md5(md5($p).$s) :Only one salt
>Only in file 2: md5_gen(1003) md5(md5($p).md5($p)):Raw
>Only in file 2: md5_gen(1008) md5($p.$s) [joomla]:Only one salt
>Only in file 2: Salted SHA(8x):Many salts
>Only in file 2:  md5_gen(20): Cisco PIX (MD5 salted):Only one salt
>Only in file 2:  md5_gen(20): Cisco PIX (MD5 salted):Many salts
>Only in file 2:  md5_gen(3): md5(md5(md5($p))) :Raw
>Only in file 2:  md5_gen(24): sha1($p.$s):Only one salt
>Only in file 2:  md5_gen(21): HTTP Digest Access Auth:Many salts
>Only in file 2:  md5_gen(13): md5(md5($p).md5($s)) :Many salts
>Only in file 2: Raw SHA-1(8x):Raw
>Only in file 2:  md5_gen(8): md5(md5($s).$p) :Only one salt
>Only in file 2:  md5_gen(12): md5(md5($s).md5($p))  (IPB) :Only one salt
>Only in file 2:  md5_gen(4): md5($s.$p)  (OSC) :Only one salt
>Only in file 2:  md5_gen(15): md5($u.md5($p).$s) :Many salts
>Only in file 2:  md5_gen(10): md5($s.md5($s.$p)) :Only one salt
>Only in file 2:  md5_gen(9): md5($s.md5($p)) :Many salts
>Only in file 2:  md5_gen(1): md5($p.$s)  (joomla) :Only one salt
>Only in file 2:  md5_gen(4): md5($s.$p)  (OSC) :Many salts
>Only in file 2: HMAC MD5:Raw
>Only in file 2: md5_gen(1006)
>md5(md5(md5(md5(md5(md5(md5(md5($p)))))))):Raw
>Only in file 2:  md5_gen(18): md5($s.Y.$p.0xF7.$s) (Post.Office MD5)
>:Only one salt
>Only in file 2:  md5_gen(18): md5($s.Y.$p.0xF7.$s) (Post.Office MD5)
>:Many salts
>Only in file 2:  md5_gen(15): md5($u.md5($p).$s) :Only one salt
>Only in file 2:  md5_gen(17): phpass ($P$ or $H$) :Raw
>Only in file 2:  md5_gen(25): sha1($s.$p):Many salts
>Number of benchmarks:           90
>Minimum:                        2.85147 real, 2.82985 virtual
>Maximum:                        14.38943 real, 14.38943 virtual
>Median:                         4.71793 real, 4.78195 virtual
>Median absolute deviation:      0.72361 real, 0.69465 virtual
>Geometric mean:                 5.45299 real, 5.45146 virtual
>Geometric standard deviation:   1.39480 real, 1.39482 virtual
>
>(BTW, that's 1 GHz P3, gcc 3.4.5 vs. 3.15 GHz Core 2, gcc 4.6.2.)
>
>So 90 benchmarks stayed under the same name, whereas 68 changed their
>name.  Of the 68, it was about "MMX" for 65 and "(8x)" (in the x86-64
>build) for 3.  Here they are:
>
>Only in file 2: Salted SHA(8x):Only one salt
>Only in file 2: Salted SHA(8x):Many salts
>Only in file 2: Raw SHA-1(8x):Raw
>
>You can try SSE2 and other builds as well.  I think/hope that addressing
>the above will take care of them all (including those with "SSE2" in
>place of "MMX"), but this is worth checking.
>
>Oh, while you're at it, maybe also remove the leading spaces for md5_gen
>(or for dynamic now).
>
>Thanks,
>
>Alexander

Powered by blists - more mailing lists

Your e-mail address:

Powered by Openwall GNU/*/Linux - Powered by OpenVZ