Openwall GNU/*/Linux - a small security-enhanced Linux distro for servers
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 04 Aug 2011 13:28:55 +0200
From: magnum <rawsmooth@...dband.net>
To: john-dev@...ts.openwall.com
Subject: Re: issues with 1.7.8-jumbo-5

On 2011-08-04 13:13, magnum wrote:
> The bug is in --pipe

And here it is: An assumption that average line length is at most 16:

	max_pipe_words = (db->options->max_wordfile_memory/16);

Once you get to a block of lines that has a longer average line length, 
we will start overwriting stuff. Not sure what's the best fix for this 
(increasing it to 256 does not fix it for the Rockyou list, and even if 
it would it would be very ineffective) but now at least we have --stdin 
working again.

Maybe we should assume format.maxlength instead, *and* truncate when 
reading? I'll let Jim decide.

magnum

Powered by blists - more mailing lists

Your e-mail address:

Powered by Openwall GNU/*/Linux - Powered by OpenVZ