Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Thu, 14 Jul 2011 13:28:07 +0400
From: Solar Designer <solar@...nwall.com>
To: john-dev@...ts.openwall.com
Subject: Re: Error building jumbo-2-omp-des-7-mscash2-2 in Owl 32-bit, and fix

Robert,

On Mon, Jul 11, 2011 at 02:37:07PM -0400, Robert B. Harris wrote:
> The following is for john-1.7.8 on Owl 3.0-current 2011/03/12 x86 32-bit,

BTW, there's no "Owl 3.0-current", there's just "Owl-current" (of a
certain date), which has moved away from full 3.0 binary compatibility
with the OpenSSL version change, and there's "Owl 3.0-stable".  You
appear to be using the former.

I do see how our Owl branches/versions may be confusing, but I don't see
how we could make it simpler without dropping useful properties - having
a stable branch with binary compatibility to the previous release and
having a development branch where we can move to newer libraries.

> with the following patches:
>         john-1.7.8-jumbo-2.diff
>         john-1.7.8-jumbo-2-plugin.diff
>         john-1.7.8-omp-des-7.diff
>         john-1.7.8-jumbo-2-plugin-mscash2-2.diff
> 
> I'm getting an error at DES_bs_b.c, see at the end, when I try to compile with "make clean linux-x86-sse2".
> 
> However, if I compile with "make clean linux-x86-sse2i", I get past this but it errors out, later on.
> I don't get any errors with the same build, with the exception of omp 4, instead of omp 7 on Owl 32-bit.
> 
> Also, I don't get any of these errors with the same source or the omp 4 source compiled with "make clean linux-x86-64", on Owl 64 bit.
> 
> So, since it says -msse2 needs to be added, the simpliest place I could add it where it worked was in OMPFLAGS.  
> So I tested with "OMPFLAGS = -fopenmp -msse2".  I'm pretty sure this isn't the best place to put it, but was the easiest for my test.
> After I added this, it compiled!

Actually, this is precisely what I did myself during my own test builds
of -omp-des-7 for 32-bit x86 when someone on john-users asked about that
a few months ago.

> So, do you agree this needs to be added permanently?  If so, where is the best place?  If not, what is the solution?

Since the patch is a hack anyway, adding this to OMPFLAGS is fine.
It should have no effect for x86-64 builds, where -msse2 is implied.

Thanks,

Alexander

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.