Openwall GNU/*/Linux - a small security-enhanced Linux distro for servers
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 06 Jun 2011 19:14:32 +0200
From: magnum <rawsmooth@...dband.net>
To: john-dev@...ts.openwall.com
Subject: Re: ETA for incremental

On 2011-06-04 21:48, Solar Designer wrote:
> magnum -
>
> On Sat, Jun 04, 2011 at 09:17:40PM +0200, magnum wrote:
>> Yes it may need some rework. It's calculated from percent done and time done (this is old code). It's not an overflow but at 0.00% it will show "best case" - it calculates ETA assuming an actual progress of 0.009%.
>>
>> At first I muted ETA (for all modes) until we have 0.01% but I reverted that and put the '>' in there instead. Rest is pretty much the old code. Maybe that muting was better after all, especially for full Incremental. Very easy fix.
>
> Yes, I think muting until we reach 0.05% (20% precision) will be better,
> although not basing this on the rounded for display progress percentage
> would be better yet.
>
> Perhaps submit a patch for -jumbo-6?

Done and posted. I do not agree that we should mute it all the way to 
0.05% as I prefer a ballpark figure over nothing, but instead of arguing 
I made it a john.conf option :-)

BTW I also dropped the "ETA:" text when we reach 100%, like this:

magnum@...ge:~/src/john/john/src$ ../run/john ../test/NT_tst.in -inc:digits
Loaded 1320 password hashes with no different salts (NT MD4 [128/128 X2 
SSE2-16])
Remaining 1245 password hashes with no different salts
guesses: 0  time: 0:00:00:01 23.00% (ETA: Mon Jun  6 19:02:59 2011) 
c/s: 31825M  trying: 32242451 - 32242941
guesses: 0  time: 0:00:00:02 39.13% (ETA: Mon Jun  6 19:03:00 2011) 
c/s: 27067M  trying: 47111564 - 47119526
guesses: 0  time: 0:00:00:06 100.00% (Mon Jun  6 19:03:01 2011)  c/s: 
23055M  trying: 83536787 - 83536784


It's not hard tested but I think it's proper, it is tested with and 
without MPI. I believe it will "catch" any malformed (or missing) config 
line and default to 0.05%.

magnum

Powered by blists - more mailing lists

Your e-mail address:

Powered by Openwall GNU/*/Linux - Powered by OpenVZ