[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 31 May 2011 14:20:24 -0700
From: Dhiru Kholia <dhiru.kholia@...il.com>
To: john-dev@...ts.openwall.com
Subject: Re: add support for cracking RAR archive passwords [GSoC
first cut]
On Tue, May 31, 2011 at 11:26 AM, magnum <rawsmooth@...dband.net> wrote:
> What is this change in loader.c for? Is it really needed?
>
> --- a/src/loader.c Wed Apr 27 21:03:01 2011 -0700
> +++ b/src/loader.c Fri Apr 29 05:08:28 2011 -0700
> @@ -260,7 +260,9 @@
> return 0;
> }
> *p = 0;
> - *login = no_username;
> + if(strlen(*login) >= 6 && (strncmp(*login, "$rar3$", 6)
> ==0));
> + else
> + *login = no_username;
> }
>
> if (source) strcpy(source, line ? line : "");
>
> maybe it can be put in the new prepare() function for a future Jumbo but I'm
> not sure what is intended.
These changes are not needed and I have removed them now. Thanks
magnum. Adding support for "rar -p" is still in the works and I will
publish the new patch when it is done (sounds okay or should I publish
a new patch just with the loader.c changes removed?). (stuck with
parsing rar files ATM).
Solar, some test rar files are included with the patch itself. I will
create the wiki page and upload them separately too. Thanks.
--
Cheers,
Dhiru
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
