Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 15 Mar 2011 16:35:36 -0600
From: RB <aoz.syn@...il.com>
To: john-dev@...ts.openwall.com
Subject: Re: Speedup of x86 .S build of raw-sha1 format

On Tue, Mar 15, 2011 at 16:28, jfoug <jfoug@....net> wrote:
> Here is about a 10% speedup.  A very trivial change.

[snip]

> +           //memset(saved_key, 0, sizeof(saved_key));
> +           memset(saved_key, 0, 64*MMX_COEF);

For the memory-management poor but intellectually curious on the list,
can you explain why?  Is it just because we avoid sizeof() in what I
presume is a tight loop?  What happens if saved_key is larger than
64*MMX_COEF, or can that even happen?

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.